[gstreamer-bugs] [Bug 636037] New: audiotestsrc timestamps are imprecise in general

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=636037
  GStreamer | gst-plugins-base | git

           Summary: audiotestsrc timestamps are imprecise in general
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: jordi.burguet.castell at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=175448)
 View: https://bugzilla.gnome.org/attachment.cgi?id=175448
 Review: https://bugzilla.gnome.org/review?bug=636037&attachment=175448

use gst_util_uint64_scale_int_round() to compute timestamps

The audiotestsrc element sets and reports the timestamps of the buffers it
creates with a small error.

Basically, by using gst_util_uint64_scale_int() in some places, the timestamp
can be off by almost a nanosecond. In our pipeline we are sensitive to any
error in the timestamp, and because of this (small) problem we can't use
audiotestsrc to test it.

Fortunately, the fix is very easy. In audiotestsrc the timestamp (in
"next_time") is computed always from next_sample, so it can be solved by
changing gst_util_uint64_scale_int() to gst_util_uint64_scale_int_round() (note
the extra "_round") everywhere. Patch attached.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.