[gstreamer-bugs] [Bug 612313] qtdemux: Post AAC profile/level in caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=612313
  GStreamer | gst-plugins-good | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO

--- Comment #9 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-10-01 10:45:18 UTC ---
Ok, I've pushed this now:

 commit 845a3d6c3d1b013c2450f0d09a0c1e583e7ab4cf
 Author: Arun Raghavan <arun.raghavan at collabora.co.uk>
 Date:   Fri Apr 30 14:06:27 2010 +0530

    qtdemux: Export AAC profile and level in caps

    This exports the AAC profile and level in caps for use as metadata and
    (eventually) for more fine-grained selection of decoders at
    caps-negotiation time. (Doesn't work for HE-AAC yet though.)

    https://bugzilla.gnome.org/show_bug.cgi?id=612313

along with an unrelated fix for the channel override in this code section.


Main question I have is this: why is the _set_level_and_profile() call within
the if (codec_data_len == 2) block? Shouldn't it be outside that block, with
the codec utils function handling this correctly?

It seems to me that the caller of the codec utils functions shouldn't have to
worry about the HE-AAC thing - if we have to worry about that, then maybe the
codec utils API isn't quite right (not passed enough information or somesuch).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.