[gstreamer-bugs] [Bug 631200] flacparse: major performance improvements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=631200
  GStreamer | gst-plugins-bad | git

--- Comment #15 from Sebastian Dröge <slomo at circular-chaos.org> 2010-10-03 11:50:02 UTC ---
Well, let's not argue about that here (and FWIW I'm successfully using git-bz).

>From a short look at your patches you're still parsing the complete FLAC
frames. Didn't you say yesterday on IRC that you're only looking for a) a sync
marker and b) that a valid frame header follows and then simply push everything
until the next valid sync marker/frame header downstream?

And what's the reason for dropping the optional CRC16 frame check (which
defaults to FALSE)? I added it some time ago and planned to post a message on
the bus for broken frames to provide a tool for checking FLAC files for
corruptions.

Other than that the patches look good from a first glance... will merge them
later and do a deeper review then. After optimizing GstBitReader a bit :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.