[gstreamer-bugs] [Bug 631200] flacparse: major performance improvements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=631200
  GStreamer | gst-plugins-bad | git

--- Comment #24 from Felipe Contreras <felipe.contreras at gmail.com> 2010-10-04 14:55:32 UTC ---
(In reply to comment #20)
> (From update of attachment 171598 [details])
> Yes, I don't :) The property was added to add a tool for checking if a FLAC
> file is valid and it's disabled by default.

Which is useless most of the time. I would have a separate tool for that, a
separate branch, or at least add G_UNLIKELY.

> The requested_frame_size
> calculations everywhere are there for giving baseparse a better estimate of the
> possible framesize by looking at the minimum/maximum frame sizes in the flac
> streaminfo, etc.

It's not used at all, anywhere. Not on flacparse, not on baseparse... nowhere.

> The gotos are there to keep the error cases outside the normal code flow.

They do two things, print a message on EOS, and need streaminfo, and return -1
or -2 depending on that, but then, that FALSE is returned in
gst_flac_parse_check_valid_frame() regardless. In my resulting code EOS is
still printed, so nothing is lost, only the "need streaminfo" message, which is
useless IMO; I never saw that, can be done much more easily with a single 'if'
at the top, and I don't think it matters after the reorganization.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.