[gstreamer-bugs] [Bug 628408] Use GDateTime that has been released

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Oct 12 05:17:38 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=628408
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172133|none                        |accepted-commit_now
             status|                            |

--- Comment #8 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-10-12 12:17:35 UTC ---
(From update of attachment 172133)
>Use GDateTime internally on GstDateTime if glib already
>provides it.

>--- a/gst/glib-compat-private.h
>+++ b/gst/glib-compat-private.h
>@@ -8,7 +8,6 @@
> #ifndef __GLIB_COMPAT_PRIVATE_H__
> #define __GLIB_COMPAT_PRIVATE_H__
> 
>-#include "gst_private.h" /* for g_warning */
> #include <glib.h>
> 
> G_BEGIN_DECLS
>@@ -17,6 +16,10 @@ G_BEGIN_DECLS
> typedef struct stat GStatBuf;
> #endif
> 
>+#if GLIB_CHECK_VERSION(2,26,0)
>+#define GLIB_HAS_GDATETIME
>+#endif
>+
> /* copies */
> 
> /* adaptations */
>diff --git a/gst/gstdatetime.c b/gst/gstdatetime.c
>index e02ea25..00cab13 100644
>--- a/gst/gstdatetime.c
>+++ b/gst/gstdatetime.c
>@@ -21,8 +21,12 @@
> #include "config.h"
> #endif
> 
>+#include "glib-compat-private.h"

Since it's not used anywhere else, maybe this define should just go into
gstdatetime.c instead?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list