[gstreamer-bugs] [Bug 503592] gstpad.c does many ref/unref of peer pad in dataflow

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=503592
  GStreamer | gstreamer (core) | git

--- Comment #15 from Marco Ballesio <gibrovacco at gmail.com> 2010-10-13 07:41:14 UTC ---
I think this patch is great, definitely a big leap forward!

If it's allowed, I'd point out just a couple of trivial things:

- in gst_pad_chain_data_unchecked you're passing the argument "cache" and then
reassigning it to NULL. In code readability's sake, wouldn't it be better to
use a local variable for this? 

- even though the functions "pad_take_cache", "pad_free_cache", "pad_put_cache"
and "pad_invalidate_cache" should be implicitly inlined by the gcc, I suggest
to explicitly add an "inline" statement to make this optimisation more portable
and make it clear to the reader.

P.S. I'll try and run performance checks on x86 and Atom when possible,
hopefully already this week.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.