[gstreamer-bugs] [Bug 632988] [discoverer] gst_caps_ref() critical for substreams of unknown streams

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=632988
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |slomo at circular-chaos.org
     Ever Confirmed|0                           |1

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2010-10-23 19:13:07 UTC ---
Simple to fix by the following patch but I think there shouldn't be a substream
for this at all



--- a/gst-libs/gst/pbutils/gstdiscoverer-types.c
+++ b/gst-libs/gst/pbutils/gstdiscoverer-types.c
@@ -539,7 +539,7 @@ gst_discoverer_stream_info_get_caps
(GstDiscovererStreamInfo * info)
 {
   g_return_val_if_fail (GST_IS_DISCOVERER_STREAM_INFO (info), NULL);

-  return gst_caps_ref (info->caps);
+  return info->caps ? gst_caps_ref (info->caps) : NULL;
 }

 /**

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.