[gstreamer-bugs] [Bug 632885] Gaudi Effects dynamically controllable parameters [review]

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=632885
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173011|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge <slomo at circular-chaos.org> 2010-10-23 19:18:29 UTC ---
Review of attachment 173011:
 --> (https://bugzilla.gnome.org/review?bug=632885&attachment=173011)

This patch does not do what it claims to do, it adds some properties to random
effects.

(But you should base the effect elements on GstVideoFilter instead of
GstBaseTransform)

Please change the commit message and fix the gstplugin.h changes

::: gst/gaudieffects/gstplugin.h
@@ -3,3 @@
  * Copyright (C) 2005 Thomas Vander Stichele <thomas at apestaart.org>
  * Copyright (C) 2005 Ronald S. Bultje <rbultje at ronald.bitfreak.net>
- * Copyright (C) 2010 Luis de Bethencourt <luis at debethencourt.com>

This change looks inverted

@@ -48,1 @@


And this one too and everything else in this file

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.