[gstreamer-bugs] [Bug 632779] gstdataqueue: Only emit g_cond_signal when needed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=632779
  GStreamer | gstreamer (core) | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172915|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2010-10-23 19:31:35 UTC ---
Review of attachment 172915:
 --> (https://bugzilla.gnome.org/review?bug=632779&attachment=172915)

Looks good to me in general but you realize that GST_PADDING usally is 4 and
there's no padding left after your change? Also you add two gbooleans (i.e.
int) but remove 2 pointers from the padding, I don't think you can assume that
the struct padding will be the same on all architectures and the 2 booleans
both take the space of a pointer.

Maybe we could add a private struct or use a single integer for the two
booleans?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.