[gstreamer-bugs] [Bug 632778] Optimisations to GstBaseSink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=632778
  GStreamer | gstreamer (core) | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172911|none                        |reviewed
             status|                            |

--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2010-10-23 19:33:55 UTC ---
Review of attachment 172911:
 --> (https://bugzilla.gnome.org/review?bug=632778&attachment=172911)

Looks good

::: libs/gst/base/gstbasesink.c
@@ +238,2 @@
   /* the last buffer we prerolled or rendered. Useful for making snapshots */
+  gint enable_last_buffer;      /* atomic */

Shouldn't this be marked as volatile?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.