[gstreamer-bugs] [Bug 586570] Add GAP Flag support to audioresample

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=586570
  GStreamer | gst-plugins-base | git

--- Comment #21 from Leo Singer <lsinger at caltech.edu> 2010-10-31 23:41:05 UTC ---
I have all of the unit tests passing now; I'll provide a new version shortly. 
I noticed that an earlier version of my patch was accidentally pushed on
master, then reverted, so I'll provide a set of patches.  The first will revert
the revert, the second will make the unit tests pass, and the remainder will
address Stefan's comments individually.

(In reply to comment #18)
> wouldn't you need to zero buf? And if so, wouldn'ät it be easier to support
> passing NULL and make process writing zeros in that case?
> 
> @@ +807,3 @@
> +  g_free(buf);
> +
> +  g_assert(in_len == in_processed);
> 
> that makes no sense here, as you just set this above.

Actually, buf is storage for the output of resample->funcs->process, which is
just discarded in gst_audio_resample_dump_drain.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.