[gstreamer-bugs] [Bug 628548] [mpegtsmux][PATCH]Initialize PES packet before getting the header size

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=628548
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
         AssignedTo|slomo at circular-chaos.org    |gstreamer-bugs at lists.source
                   |                            |forge.net
   Target Milestone|HEAD                        |0.10.21

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2010-09-04 13:17:42 UTC ---
commit 4668330bdc810256027637cf9aac3178e769d6b9
Author: Andoni Morales Alastruey <ylatuya at gmail.com>
Date:   Wed Sep 1 22:05:43 2010 +0200

    mpegtsmux: Initialize PES packet before getting the header size.

    The PES header length is calculated before setting the dynamic flags, retur
    a wrong value. Small frames that should be sent in a single TS packet are
    spawned to a new packet because of that error. For audio streams where a si
    frame can cope in one TS packet it introduces a huge overhead.

    For a 100B packet, we prepare a TS packet with a payload of(100+9)B. Then, 
    write the TS header using this value in tsmux_write_ts_header, and call
    tsmux_stream_get_data(). The dynamic flags where not set yet and now
    tsmux_stream_pes_header_length() returns 14B instead of 9B. The payload of 
    TS packet is 114B, 5B more than what was calculated. 109B are sent in a fir
    packet and the remaining 5B are sent in another one.

    Fixes bug #628548.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.