[gstreamer-bugs] [Bug 396774] Make GstElementDetails extensible

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=396774
  GStreamer | gstreamer (core) | git

--- Comment #37 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-09-06 08:23:02 UTC ---
> Created an attachment (id=169369)
 View: https://bugzilla.gnome.org/attachment.cgi?id=169369
 Review: https://bugzilla.gnome.org/review?bug=396774&attachment=169369

> allow arbitrary plugin metadata
> 
> Fixed and // comment and gst_element_class_add_meta_data(). Also now using a
> gpointer in the public headers and casting in the implementation.

Looks ok to me. Three more comments:

 - maybe make gst-inspect only use the public API for now?
   (since we don't support arbitrary keys, there's no need to
   iterate yet, so it's safer not to do the cast to GstStructure
   here, for the unlikely corner case where
   gst-inspect version != libgstreamer version)

 - is the deserialisation of an empty meta string correct here? 

 - lastly, we could put the GstStructure * into a GstElementFactoryPrivate
   instead, then we keep it private but also don't need the casts
   (sorry, didn't think of that before)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.