[gstreamer-bugs] [Bug 628214] Add support to RTSP initiation through SDP files

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Sep 6 04:50:05 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=628214
  GStreamer | gst-plugins-good | git

--- Comment #12 from Wim Taymans <wim.taymans at gmail.com> 2010-09-06 11:50:01 UTC ---
(In reply to comment #9)
> (In reply to comment #7)
> 
> Thank you for the review, my notes below.
> 
> 
> In sdpdemux the '\n' are converted with ';' . It's useful, for instance, to
> easily pass the uri from command line. They're then converted back to '\n' to
> let SDPMessage parse the content properly. It's trivial for me to remove all
> the mangling/demangling if we so decide.

OK, I didn't realize that you want to pass an SDP from the command line like
that. You can just as well cut and paste an SDP into a property with \n and
all. Also, unfortunately, ; can be part of any string in the SDP (Appendix A,
safe) 

> 
> But it's not clear to me what would happen if we set the SDP content after the
> streaming has already been initiated. I guess it would be more proper to check
> the state of the element here.

Yeah, just like any property that doesn't take immediate effect after a certain
state change (like the location property) we mark them with the right flags on
the paramspec. Checking the state of the element is not needed. 

> > There is no need to parse the control url, this will happen later.
> 
> If the control url is not set properly the function gst_rtspsrc_open_from_sdp
> will not find the control information and thus attempt to open a connection on
> the 'sdp://' uri (which, of course, cannot be handled). After this fails, no
> connection will be available to propagate further RTSP messages (e.g. SETUP).

The second thing that _open_from_sdp does is parse the control url from the
SDP.
http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/gst/rtsp/gstrtspsrc.c#n5172

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list