[gstreamer-bugs] [Bug 621929] Move jack plugins from gst-plugins-bad to gst-plugins-good

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=621929
  GStreamer | gst-plugins-bad | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #169371|none                        |needs-work
             status|                            |

--- Comment #3 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-09-06 19:44:18 UTC ---
Review of attachment 169371:
 --> (https://bugzilla.gnome.org/review?bug=621929&attachment=169371)

Looks good. Just a small change needed.

::: ext/jack/gstjackaudiosink.c
@@ +690,3 @@
+  g_object_class_install_property (gobject_class, PROP_CLIENT,
+      g_param_spec_boxed ("client", "JackClient", "Handle for jack client",
+          GST_TYPE_JACK_CLIENT, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

Please add GST_PARAM_MUTABLE_READY (its not enforced, but helps to document the
restriction).

::: ext/jack/gstjackaudiosrc.c
@@ +713,3 @@
+      g_param_spec_boxed ("client", "JackClient", "Handle for jack client",
+          GST_TYPE_JACK_CLIENT, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
+

Same as in sink.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.