[gstreamer-bugs] [Bug 628214] Add support to RTSP initiation through SDP files

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=628214
  GStreamer | gst-plugins-good | git

--- Comment #13 from Marco Ballesio <gibrovacco at gmail.com> 2010-09-08 07:20:18 UTC ---
(In reply to comment #12)
> 
> OK, I didn't realize that you want to pass an SDP from the command line like
> that. You can just as well cut and paste an SDP into a property with \n and
> all. Also, unfortunately, ; can be part of any string in the SDP (Appendix A,
> safe) 

I agree with you, fwiw it's more complex to pass from the command-line a string
with '\n' through an option than to translate them with ';' and then re-convert
back to '\n' with the heuristic in my implementation. To conclude I must admit
that, being it an heuristic, it will fail in some possible cases, so I'll go
the way you've proposed.

> 
> > 
> > But it's not clear to me what would happen if we set the SDP content after the
> > streaming has already been initiated. I guess it would be more proper to check
> > the state of the element here.
> 
> Yeah, just like any property that doesn't take immediate effect after a certain
> state change (like the location property) we mark them with the right flags on
> the paramspec. Checking the state of the element is not needed. 
> 
> > > There is no need to parse the control url, this will happen later.
> > 
> > If the control url is not set properly the function gst_rtspsrc_open_from_sdp
> > will not find the control information and thus attempt to open a connection on
> > the 'sdp://' uri (which, of course, cannot be handled). After this fails, no
> > connection will be available to propagate further RTSP messages (e.g. SETUP).
> 
> The second thing that _open_from_sdp does is parse the control url from the
> SDP.
> http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/gst/rtsp/gstrtspsrc.c#n5172

Yes, but the problem here is originated from gst_rtspsrc_uri_set_uri which sets
the uri containing the sdp:// address in the first stance. After that,
gst_rtsp_conninfo_connect attempts to connect to that URI which is, as I
already pointed out, quite difficult. The control URI parsing is the "less
invasive" approach to address the issue.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.