[gstreamer-bugs] [Bug 624338] [pulsesink] Handle pulse context separate from the ringbuffers and share them

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=624338
  GStreamer | gst-plugins-good | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ensonic at sonicpulse.de

--- Comment #42 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-09-13 14:05:31 UTC ---
(In reply to comment #38)
> Created an attachment (id=168102)
 View: https://bugzilla.gnome.org/attachment.cgi?id=168102
 Review: https://bugzilla.gnome.org/review?bug=624338&attachment=168102

> pulsesink: share the PA context between all clients with the same name
> 
> Avoid to create a new PA context for each new client by using a hash
> table containing the list of ring-buffers and the shared PA context
> for each client. Doing this will improve application memory usage in
> the cases where multiple pipelines involving multiple pulsesink
> elements are used.
> 
> Fixes bug #624338.
> 
> Simpler patch, also fixes invalid memory access when destroy the context.

Have you done any measurements on the memory saving? I am a bit lost what
problem the patch actually tried to solve. I have reworked the patch under bug
#628996 - please check that the original goals are still covered.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.