[gstreamer-bugs] [Bug 621929] [PLUGIN-MOVE] move jack plugin from -bad to -good
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Sep 14 07:50:05 PDT 2010
https://bugzilla.gnome.org/show_bug.cgi?id=621929
GStreamer | gst-plugins-good | git
Wim Taymans <wim.taymans> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |wim.taymans at gmail.com
--- Comment #13 from Wim Taymans <wim.taymans at gmail.com> 2010-09-14 14:49:58 UTC ---
+ case PROP_CLIENT:
+ if (GST_STATE (src) == GST_STATE_NULL ||
+ GST_STATE (src) == GST_STATE_READY) {
+ src->jclient = g_value_get_boxed (value);
+ }
+ break;
There is no need to check the states. It can't be done in a threadsafe way and
the app has no way of knowning if it actually worked or not. You would just use
the flags on the paramspec, which is a hint that the change only takes effect
when in those states.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the Gstreamer-bugs
mailing list