[gstreamer-bugs] [Bug 627565] [xoverlay][win64] gulong can't hold a HANDLE

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627565
  GStreamer | gst-plugins-base | 0.10.x

--- Comment #7 from David Schleef <ds at schleef.org> 2010-09-15 01:38:05 UTC ---
(In reply to comment #6)
> I wonder if the size check should be skipped here if the actual handle value to
> be set fits into a gulong, to preserve maximum backwards compatibility (but
> maybe this only affects win64 anyway which was broken before so we don't really
> care too much?)?

My thought was that only Win64 is affected, and presumably anything on Windows
will get fixed quickly.

> Should we rename this field to match the new function names? (We might also
> want to provide API to detect this kind of message and parse the info later).

Definitely change -uintptr.  Changing the structure name seems like not much
benefit.

> Looks good to me otherwise. Might want to sprinkle in some more GST_WARNINGs if
> elements don't implement the new vfunc yet or call the old methods.

Good idea.  Will fix up and push shortly.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.