[gstreamer-bugs] [Bug 630205] [icydemux][PATCH] Forward tag events downstrem

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=630205
  GStreamer | gst-plugins-good | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #170712|none                        |needs-work
             status|                            |

--- Comment #2 from Edward Hervey <bilboed at gmail.com> 2010-09-21 06:56:24 UTC ---
Review of attachment 170712:
 --> (https://bugzilla.gnome.org/review?bug=630205&attachment=170712)

::: gst/icydemux/gsticydemux.c
@@ +381,3 @@
         return gst_pad_event_default (pad, event);
+      case GST_EVENT_TAG:
+        if (icydemux->srcpad) {

That's almost exactly the same code as in gst_icydemux_parse_and_send_tags(),
The code could be made clearer by having a gst_icydemux_found_tags(icydemux,
tags) method.

@@ +383,3 @@
+        if (icydemux->srcpad) {
+          GST_DEBUG_OBJECT (icydemux, "Forwarding tag event on src pad");
+          gst_pad_push_event (icydemux->srcpad, event);

You lose the reference on the event here. Either you keep one or you add a
break to avoid storing the event below.

@@ +393,3 @@
+          gst_tag_list_insert (icydemux->cached_tags, tags,
+              GST_TAG_MERGE_REPLACE);
+        }

Looks like you're missing a break.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.