[gstreamer-bugs] [Bug 630205] [icydemux][PATCH] Forward tag events downstrem

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=630205
  GStreamer | gst-plugins-good | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #170867|none                        |needs-work
             status|                            |

--- Comment #5 from Edward Hervey <bilboed at gmail.com> 2010-09-23 06:31:32 UTC ---
Review of attachment 170867:
 --> (https://bugzilla.gnome.org/review?bug=630205&attachment=170867)

Apart from that minor comment, looks good.

::: gst/icydemux/gsticydemux.c
@@ +382,3 @@
+    gst_event_parse_tag (event, &tags);
+    return gst_icydemux_tag_found (icydemux, tags);
+  }

You're leaking the event.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.