[gstreamer-bugs] [Bug 625396] gst_debug_remove_log_function doesn't remove default log handler

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=625396
  GStreamer | gstreamer (core) | 0.10.30

--- Comment #9 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-09-23 11:33:10 UTC ---
Created an attachment (id=170893)
 View: https://bugzilla.gnome.org/attachment.cgi?id=170893
 Review: https://bugzilla.gnome.org/review?bug=625396&attachment=170893

info: add gst_debug_set_log_function() and deprecate old API

commit 20c5a8dd47562061a5c823fa4b633bfa6cae2d72
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Thu Sep 23 12:14:07 2010 +0100

    info: add gst_debug_set_log_function() and deprecate old API

    Add gst_debug_set_log_function() to set the current log function
    whilst replacing the previous log function. This is mainly to
    work around problems with the _add()/_remove() API on some platforms
    (e.g. win32 and Solaris) where _remove_log_function(gst_debug_log_default)
    doesn't always work properly. The new API also seems more straight-forward
    though, and since no one could really come up with a use case for multiple
    log functions, it seems best to just deprecate the old API.

    API: add gst_debug_set_log_function()
    API: deprecate gst_debug_add_log_function()
    API: deprecate gst_debug_remove_log_function()
    API: deprecate gst_debug_remove_log_function_by_data()


Just like _add_log_function() we also don't allow for a DestroyNotify callback
in _set_log_function(), because we want to avoid locking in the log handler
code path, and I don't see how we can trivially implement this without (doesn't
seem worth putting effort into more sophisticated approaches just for this
either IMHO). We could of course just add the DestroyNotify callback to the
API, but document that it will never be called at the moment. Not sure if that
makes things better for bindings / gobject-introspection or if it doesn't
really matter.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.