[gstreamer-bugs] [Bug 621929] [PLUGIN-MOVE] move jack plugin from -bad to -good

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Sep 23 12:06:58 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=621929
  GStreamer | gst-plugins-good | git

--- Comment #16 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-09-23 19:06:56 UTC ---
> There is no need to check the states. It can't be done in a threadsafe way and
> the app has no way of knowing if it actually worked or not.

The app has a way of knowing: it can check via g_object_get() if the setting
was applied or not.

But since the property is flagged correctly with GST_PARAM_MUTABLE_*, setting
the property in other states is a programming error anyway. I think this could
(should?) be checked with a g_return_if_fail() or so at the beginning of the
function some day. There's a convenience macro in bugzilla somewhere for this,
but we didn't think it was quite right yet I guess..

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list