[gstreamer-bugs] [Bug 630447] rtpsession: relax third-party collision detection

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=630447
  GStreamer | gst-plugins-good | unspecified

Olivier Crete (Tester) <tester> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #170944|none                        |reviewed
             status|                            |

--- Comment #1 from Olivier Crete (Tester) <tester at tester.ca> 2010-09-23 19:07:04 UTC ---
Review of attachment 170944:
 --> (https://bugzilla.gnome.org/review?bug=630447&attachment=170944)

::: gst/rtpmanager/rtpsession.c
@@ +1109,3 @@
+    if (arrival->time > source->last_activity) {
+      GstClockTime inactivity_period = arrival->time - source->last_activity;
+      if (inactivity_period > 1*GST_SECOND) {

You could do that instead:
if (arrival->time > source->last_activity && arrival->time -
source->last_activity > 1 * GST_SECOND) {

Otherwise it looks good to me. Btw, the "favor-new" property is probably want
you want to use too ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.