[gstreamer-bugs] [Bug 630452] rtpbin: Make cleaning up sources in rtp_session_on_timeout MT safe

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Sep 24 06:39:36 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=630452
  GStreamer | gst-plugins-good | unspecified

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |wim.taymans at gmail.com
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.26

--- Comment #1 from Wim Taymans <wim.taymans at gmail.com> 2010-09-24 13:39:29 UTC ---
commit ca6a512b5eef7434a2a09310317944b08323578b
Author: Pascal Buhler <pascal.buhler at tandberg.com>
Date:   Fri Sep 24 15:33:40 2010 +0200

    rtpbin: Make cleaning up sources in rtp_session_on_timeout MT safe

    Using _foreach_remove on the hashtable, while releasing the lock protecting
    that table inside the callback is not a good idea. The hashtable might
    then change (a source removed or added) while signals like on_timeout
    are being sent.

    This solution makes a copy of the table, performs the _foreach without
    actually removing any sources, but marks them for removal on a second
    iteration with the real list, but this time not letting go of the lock.

    Fixes #630452

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list