[gstreamer-bugs] [Bug 630257] GST_DEBUG_DUMP_DOT_DIR not working anymore

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Sep 25 04:26:49 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=630257
  GStreamer | gstreamer (core) | 0.10.x

--- Comment #7 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-09-25 11:26:45 UTC ---
Isn't the problem here that *reading* a property is protected with a lock in
basesink:

gst_base_sink_get_property (GObject * object, guint prop_id, GValue * value,
    GParamSpec * pspec)
{
  GstBaseSink *sink = GST_BASE_SINK (object);

  switch (prop_id) {
    case PROP_PREROLL_QUEUE_LEN:
      GST_PAD_PREROLL_LOCK (sink->sinkpad);
      g_value_set_uint (value, sink->preroll_queue_max_len);
      GST_PAD_PREROLL_UNLOCK (sink->sinkpad);


The lock around that parameter was introduced long time ago.
commit 94e1664fca0024de8b20d930b5b9f58083b91243
Author: Wim Taymans <wim.taymans at gmail.com>
Date:   Wed Jan 18 16:40:16 2006 +0000

    libs/gst/base/gstbasesink.c: Small cleanups.


Removing the locks on the property reads make it work and I get not failing
tests. I am attaching a patch that uses atomic ops (btw. the
preroll_queue_max_len variable is gint and the property guint with a range of
0...G_MAXUINT).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list