[gstreamer-bugs] [Bug 631019] Gst Plugins GL no longer OpenGL ES 2.0 friendly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=631019
  GStreamer | gst-plugins-gl | 0.10.30

Julien Isorce <julien.isorce> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |julien.isorce at gmail.com
     Ever Confirmed|0                           |1

--- Comment #3 from Julien Isorce <julien.isorce at gmail.com> 2010-09-30 18:24:19 UTC ---
The following filters are comptible to opengl ES: (see Makefile.am in
gst-plugins-gl/gst/gl:

    gstglimagesink.c \
    gstglimagesink.h \
    gstglupload.c \
    gstglupload.h \
    gstgldownload.c \
    gstgldownload.h \
    gstglfiltercube.c \
    gstglfiltercube.h \
    gstgleffects.c \
    gstgleffects.h \
    effects/gstgleffectssources.c \
    effects/gstgleffectssources.h \
    effects/gstgleffectidentity.c \
    effects/gstgleffectmirror.c \
    effects/gstgleffectsqueeze.c \


Or see "#ifndef OPENGL_ES2" in gst-plugins-gl/gst/gl/gstopengl.c

So no problem about your patch because glfilterblur and glfiltersobel are not
built if ES is detected.

Anyway, you you can also totally disable declaration and definition of those
functions if ES (instead of just disable the content)


Then about the tests, please disable building them on ES and add the change to
your patch.

SUBDIRS var from gst-plugins-gl/tests/examples/Makefile.am should be empty on
ES. (Until we make them compatible. They are not unit tests, only examples)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.