[gstreamer-bugs] [Bug 630808] [plugin-move] valve code review

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=630808
  GStreamer | gst-plugins-bad | git

Olivier Crete (Tester) <tester> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|valve code review           |[plugin-move] valve code
                   |                            |review

--- Comment #6 from Olivier Crete (Tester) <tester at tester.ca> 2010-09-30 21:49:35 UTC ---
I made it use an atomic, I fixed the doc, I re-implemented discont support
(which was broken years ago, so I guess its not critical, but it's still nice
to set the marker bit on RTP). I also committed a simple unit test for valve
which should cover most cases (since a pretty simple element).

If you guys like it, please merge it. I guess the whole thing could also be
merged into identity if we think its a better idea.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.