[Bug 638749] (Duration) queries on a source-only bin are currently not supported

Fri Apr 1 01:28:28 PDT 2011

https://bugzilla.gnome.org/show_bug.cgi?id=638749
  GStreamer | gstreamer (core) | git

--- Comment #13 from Sebastian Dröge <slomo at circular-chaos.org> 2011-04-01 08:28:21 UTC ---
* You're adding the query iterate stuff as public API. Not a good idea, please
put the header in noinst_HEADERS (or put the content in gstprivate.h)
* Add some (non-gtkdoc) documentation to the query iteration API
* You should probably do the srcpad iteration only when necessary, i.e. for
duration queries so far
* In the GstElement default query handler, maybe do the iteration stuff for the
sinkpads too instead of taking a random pad?
* Well... and the position query stuff. Just add another commit to your branch,
no need for a new bug. It's easy enough :)

* I'm not 100% sure but I think most of this can be in the GstElement default
query handler and the GstBin query handler can just chain up to it in most
cases. Could you check this?

Other than that this looks good

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.