[Bug 646570] New: baseaudiosink: don't allow aligning behind the read-segment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=646570
  GStreamer | gst-plugins-base | git

           Summary: baseaudiosink: don't allow aligning behind the
                    read-segment
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: critical
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: havard.graff at tandberg.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=184986)
 View: https://bugzilla.gnome.org/attachment.cgi?id=184986
 Review: https://bugzilla.gnome.org/review?bug=646570&attachment=184986

patch

Given a large enough drift-tolerance, one could end up in a situation
where one would keep aligning the written buffers behind the current
read-segment position. The result for the reader would be complete
silence, possible preceded by very choppy audio.

By checking the available headroom, one can determine if there is
room to do alignment, or if one should resort to a resync instead to get
the pointers back on track.

Also refactor the alignment-logic out of the render function for cleaner
code.

NOTE: I saw that the discont-message had been made into a non-warning. I
changed that back, since a discont will *always* become a glitch in the audio,
and any self-respecting application should try to avoid these, and would want
to be notified when it happens.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.