[Bug 647005] GstBus: Only create the socketpair for async message delivery if required

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=647005
  GStreamer | gstreamer (core) | unspecified

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185400|none                        |needs-work
             status|                            |

--- Comment #4 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-04-07 09:44:09 UTC ---
Review of attachment 185400:
 --> (https://bugzilla.gnome.org/review?bug=647005&attachment=185400)

::: gst/gstbus.c
@@ +150,3 @@
+    case PROP_ENABLE_ASYNC:
+      /* Do nothing, already handled in GObject::constructor */
+      break;

whooo. please not. Just handle it. See comment below.

@@ +172,3 @@
+      construct_properties);
+  bus = GST_BUS_CAST (object);
+

Imho chaining up here should call the gst_bus_set_property(). This would spare
you the ugly hack below and the global variable for the pspec.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.