[Bug 626618] jpegparse doesn't handle APP12 marker

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=626618
  GStreamer | gst-plugins-bad | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175095|none                        |needs-work
             status|                            |

--- Comment #71 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-04-07 12:30:00 UTC ---
Review of attachment 175095:
 --> (https://bugzilla.gnome.org/review?bug=626618&attachment=175095)

::: gst/jpegformat/gstjpegparse.c
@@ +518,3 @@
+      return FALSE;
+  }
+

can we write the whole thing as this to avoid unused variable warnings when
debug logging is off.
#ifndef GST_DISABLE_DEBUG
if (marker >= APP0 && marker <= APP15) {
  const gchar *id_str = NULL;
  if (!gst_byte_reader_peek_string_utf8 (reader, &id_str))
    return FALSE;
  GST_LOG_OBJECT (parse, "unhandled marker %x: '%s' skiping %u bytes",
    marker, id_str, size);
} else
#else
  GST_LOG_OBJECT (parse, "unhandled marker %x skiping %u bytes", marker,
    size);
#endif

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.