[Bug 638749] (Duration) queries on a source-only bin are currently not supported

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=638749
  GStreamer | gstreamer (core) | git

--- Comment #14 from Philippe Normand <phil at base-art.net> 2011-04-08 09:04:17 UTC ---
(In reply to comment #13)
> * You're adding the query iterate stuff as public API. Not a good idea, please
> put the header in noinst_HEADERS (or put the content in gstprivate.h)

Hum it's in noinst_HEADERS already :)

> * Add some (non-gtkdoc) documentation to the query iteration API

OK

> * You should probably do the srcpad iteration only when necessary, i.e. for
> duration queries so far

This contradicts your comment 8 or am I misunderstanding something?

> * In the GstElement default query handler, maybe do the iteration stuff for the
> sinkpads too instead of taking a random pad?
> * Well... and the position query stuff. Just add another commit to your branch,
> no need for a new bug. It's easy enough :)
> 

OK!

> * I'm not 100% sure but I think most of this can be in the GstElement default
> query handler and the GstBin query handler can just chain up to it in most
> cases. Could you check this?
> 

OK I'll check.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.