[Bug 634687] RFC: operation hints for GstElement

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=634687
  GStreamer | gstreamer (core) | git

--- Comment #5 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-04-11 13:33:58 UTC ---
Review of attachment 185691:
 --> (https://bugzilla.gnome.org/review?bug=634687&attachment=185691)

Looks good. Few small comments below. I wonder if we want to make this an
element property (then we can test this on gst-launch). The we could also use
the property-flags to document that e.g. it cannot be changed in state >=PAUSED
(imho a sensible restriction).

::: gst/gstelement.c
@@ +550,3 @@
+ * @hints: the hints to set.
+ *
+ * Sets the hints of an element. See gst_element_get_base_time().

copy'n'paste mistake here in the reference.

@@ +566,3 @@
+  GST_OBJECT_UNLOCK (element);
+
+  GST_DEBUG_OBJECT (element, "set hints=%08x, old %08x", hints, old);

This will yield a compiler warning about unused var 'old' when logging is off.

::: gst/gstelement.h
@@ +61,3 @@
+ * it to optimize for that purpose and possibly discard unneccesary actions
+ * and steps.
+ */

Maybe mention, that by default elements will prepare for all features to be
used.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.