[Bug 631580] Race in all the pad functions that don't require the pad to be active

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Apr 11 07:55:13 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=631580
  GStreamer | gstreamer (core) | git

--- Comment #9 from Sebastian Dröge <slomo at circular-chaos.org> 2011-04-11 14:55:07 UTC ---
Review of attachment 185702:
 --> (https://bugzilla.gnome.org/review?bug=631580&attachment=185702)

::: gst/gstpad.c
@@ +4275,3 @@
+      (parent = gst_pad_get_parent (pad)) == NULL) {
+    GST_PAD_STREAM_UNLOCK (pad);
+    return GST_FLOW_NOT_LINKED;

You should probably unref the buffer/event here and return WRONG_STATE instead
of NOT_LINKED

@@ +4758,3 @@
+  if (GST_PAD_IS_PARENT_REQUIRED (pad) &&
+      (parent = gst_pad_get_parent (pad)) == NULL) {
+    return GST_FLOW_NOT_LINKED;

Same here

@@ +4887,3 @@
+  if (GST_PAD_IS_PARENT_REQUIRED (pad) &&
+      (parent = gst_pad_get_parent (pad)) == NULL) {
+    return GST_FLOW_NOT_LINKED;

And here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list