[Bug 646963] rtpmanager: Only update last_rtcp_send_time when actually sending a report
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Apr 11 14:23:05 PDT 2011
https://bugzilla.gnome.org/show_bug.cgi?id=646963
GStreamer | gst-plugins-good | git
Olivier Crete (Tester) <olivier.crete> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |olivier.crete at ocrete.ca
--- Comment #1 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2011-04-11 21:22:59 UTC ---
Actually, when you send an RTCP APP report, don't you send a full Compound RTCP
packet ? In which case, I think you want to reset the RTCP timer. Or do you
send a Minimal Compound RTCP packet ?
If I read your patch correctly.. its the same as removing the if() completely,
since data.rtcp will only be set is is_rtcp_time() returns TRUE.
That said, we may want to move the timer resetting after the "on-sending-rtcp"
signal to make sure the timer is only reset if the RTCP packet has not been
supressed..
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list