[Bug 640665] basesink: drops too many buffers when there's no duration

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=640665
  GStreamer | gstreamer (core) | git

Felipe Contreras <felipe.contreras> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

--- Comment #9 from Felipe Contreras <felipe.contreras at gmail.com> 2011-04-15 17:14:44 UTC ---
(In reply to comment #7)
> - The avg_pt is not a good indication for the interframe spacing because it
> includes the synchronization jitter.

That is what you and Edward told me to do. I suggested the solution you did.

> commit f8828eace691a20f37a7dcad7766ab3e6e13331c
> Author: Wim Taymans <wim.taymans at collabora.co.uk>
> Date:   Mon Feb 14 14:00:38 2011 +0100
> 
>     basesink: improve duration calculation
> 
>     Keep track of the average distance between incomming timestamps and
>     use that to estimate the frame duration when buffers have no duration set
> on
>     them.

Yeah, this fixes the problem.

(In reply to comment #8)
> I think this fixes this bug.

Yeah, but I investigated the problem, I proposed multiple solutions, I tested
them, I discussed with multiple people, and now I'm also testing the solution.
I even asked you if I should do the patch exactly the way you ended up doing
it, and of course if I would have done it this way if you just had said so.

Yet, in the end I'm not even mentioned in the commit message. Way to
incentivize contributors.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.