[Bug 491501] Reduce usage of base_init in GstElement subclasses

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Apr 16 07:01:34 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=491501
  GStreamer | gstreamer (core) | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
 Attachment #102443|none                        |committed
             status|                            |
             Status|RESOLVED                    |NEW
         Resolution|FIXED                       |

--- Comment #30 from Sebastian Dröge <slomo at circular-chaos.org> 2011-04-16 14:01:19 UTC ---
commit a70df76c5386aa57d12cd064a75d7fe6439474ac
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Sat Apr 16 15:28:53 2011 +0200

    element: Add test for inheriting metadata/pad templates

commit 9b90d3d9c01e9730622a85aa2a156606a0e6749b
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Sat Apr 16 15:24:01 2011 +0200

    base: Update docs to say class_init instead of base_init

    And remove a useless base_init in basesrc

commit 64f6a18bada3b3dd6792199e6c58875223515b32
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Sat Apr 16 15:23:46 2011 +0200

    net: Use G_DEFINE_TYPE

commit a9e69dc3be6c6bd67e064a5d6a44f779954e6d06
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Sat Apr 16 15:23:19 2011 +0200

    gst: Don't use base_init and use G_DEFINE_TYPE instead of GST_BOILERPLATE


commit aad57970deb6a6212dbd0a7c046d656d37dc9c09
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Sat Apr 16 15:03:33 2011 +0200

    element: Inherit element metadata and pad templates from parent classes

    This allows to add pad templates and set metadata in class_init instead of
    base_init. base_init is a concept that is not supported by almost all
    languages and copying the templates/metadata for subclasses is the more
    intuitive way of doing things.

    Subclasses can override pad templates of parent classes by adding a new
    template with the same now.

    Also gst_element_class_add_pad_template() now takes ownership of the
    pad template, which was assumed by all code before anyway.

    Fixes bug #491501.




commit 92d10cbb8c17ba3b03fc6e9aa541f6a1f123c664
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Sat Apr 16 15:56:55 2011 +0200

    pango: Create a new base class for all the elements

    This prevents the ugly hack where the text_sink pad template
    was only added for textoverlay but not for the subclasses.

    Also makes this work with the core change that made
    subclasses inherit the templates of their parent class.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list