[Bug 604094] registry: do not remove features when removing a cached plugin that no longer is present

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=604094
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
             Blocks|                            |648004
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.33
         OS/Version|Windows                     |All

--- Comment #10 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-04-24 10:55:51 UTC ---
Håvard: I think your assumptions are wrong here ("if the plugin was not there
in the first place, it could not have registered any features, since the
registering of features happens through the plugin."): in this case the
features have been created when reading the registry cache at startup.

Let's try this:

commit f9625dbe5531c66be59088f032561ea76e3fc83b
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Sun Apr 24 09:58:53 2011 +0100

    registry: when removing a cached-but-no-longer-existing plugin, only remove
features that belong to it

    When a plugin file no longer exists, e.g. because it's been removed or
    renamed, don't remove all features in the registry based on the *name*
    of the plugin they belong to, but only remove those who actually belong
    to that particular plugin (object/pointer).

    This fixes issues of plugin features disappearing when a plugin .so file
    is renamed.

    https://bugzilla.gnome.org/show_bug.cgi?id=604094

commit 4926ce31c7b2fb1b42ddc12d502dbb99d41463b5
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Sun Apr 24 09:53:39 2011 +0100

    pluginfeature: store pointer to plugin in addition to the plugin name

    So we can reliably remove plugin features for a specific plugin later.

    https://bugzilla.gnome.org/show_bug.cgi?id=604094

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.