[Bug 648195] outputselector: make it "swap-safe"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=648195
  GStreamer | gstreamer (core) | git

--- Comment #6 from Håvard Graff (hgr) <havard.graff at tandberg.com> 2011-04-24 12:39:20 UTC ---
Just a comment on the one proper regression this change will have:

If you use pad-blocking on the pad that outputselector is swapping from, and
then go on to set a new active pad, you will deadlock with this patch, since
the swapping will wait for the chain-method to return, something it never will,
since it is being blocked.

The reason one would use pad-blocking with outputselector is of course that it
was not swap-safe in the first place, and it is an external way of hacking it
to do the right thing.

However, using pad-blocking have some serious drawbacks as well. If there never
arrives a buffer on the pad being blocked, you can never safely swap, and you
will end up potentially waiting forever.

Using this patch then will enable you to remove the pad-blocking hack, and have
the comfort of knowing that it is now 100% safe, and not having to worry about
the potential pad-blocking pitfalls.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.