[Bug 649040] Add volume control to qt-gstreamer example player

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Apr 30 12:13:48 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=649040
  GStreamer | qt-gstreamer | 0.10.33

George Kiagiadakis <kiagiadakis.george> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #186946|none                        |accepted-commit_now
             status|                            |

--- Comment #4 from George Kiagiadakis <kiagiadakis.george at gmail.com> 2011-04-30 19:13:45 UTC ---
Review of attachment 186946:
 --> (https://bugzilla.gnome.org/review?bug=649040&attachment=186946)

Ok, thanks. It's good to be commited to master, if you also fix those 3 details
below. You can commit directly to master if you want, or let me commit it
tomorrow.

::: examples/player/player.cpp
@@ -98,2 +99,3 @@
 }

+int Player::volume()

Oh, almost forgot... also make this function const:

int Player::volume() const

(the declaration in player.h needs to change as well)

@@ -100,0 +101,12 @@
+int Player::volume()
+{
+    if (m_pipeline) {
... 9 more ...

Indentation not completely fixed here (and the brace 2 lines above)

@@ -100,0 +101,23 @@
+int Player::volume()
+{
+    if (m_pipeline) {
... 20 more ...

Here too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list