[Bug 628284] [rsvgdec] all buffer timestamps are set to zero

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=628284
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194123|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge <slomo at circular-chaos.org> 2011-08-19 07:38:36 UTC ---
Review of attachment 194123:
 --> (https://bugzilla.gnome.org/review?bug=628284&attachment=194123)

Looks good except:

::: ext/rsvg/gstrsvgdec.c
@@ +393,3 @@
+        if (GST_BUFFER_DURATION_IS_VALID (buffer))
+          end += GST_BUFFER_DURATION (buffer);
+        GST_BUFFER_DURATION (outbuf) = end - GST_BUFFER_TIMESTAMP (outbuf);

You should set the duration to GST_CLOCK_TIME_NONE if no framerate is provided
and the input buffer has no duration either

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.