[Bug 657250] rsndvdbin attempts to modify read only metadata

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=657250
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194605|none                        |reviewed
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-08-24 14:45:12 UTC ---
(From update of attachment 194605)
>   buf = gst_buffer_ref (wrap_buf->wrapped_buffer);
>+  buf = gst_buffer_make_metadata_writable (buf);

This doesn't look right at first glance. _ref() adds a ref, whereas
make_metadata_writable() takes ownership of the existing ref, so while it may
have fixed the metadata warning, it would seem that you're one ref short now
compared to what was there previously.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.