[Bug 657257] discoverer: retrieve audio track language from tags too

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Aug 24 23:25:48 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=657257
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194625|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2011-08-25 06:25:45 UTC ---
Review of attachment 194625:
 --> (https://bugzilla.gnome.org/review?bug=657257&attachment=194625)

::: gst-libs/gst/pbutils/gstdiscoverer.c
@@ +672,3 @@
+      if (gst_tag_list_get_string (((GstDiscovererStreamInfo *) info)->tags,
+              GST_TAG_LANGUAGE_CODE, &language)) {
+        info->language = g_strdup (language);

No need to copy the string, the return value of gst_tag_list_to_string() is
owned by the caller

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list