[Bug 639055] discoverer: add support for subtitle streams

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=639055
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194599|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge <slomo at circular-chaos.org> 2011-08-25 06:37:14 UTC ---
Review of attachment 194599:
 --> (https://bugzilla.gnome.org/review?bug=639055&attachment=194599)

::: gst-libs/gst/pbutils/gstdiscoverer.c
@@ +739,3 @@
+          GST_TYPE_STRUCTURE, &tags_st, NULL);
+
+      language = gst_structure_get_string (caps_st, GST_TAG_LANGUAGE_CODE);

Why don't you use the GstTagList API here? If there are multiple language tags
in that tag list it will be stored as an array, not a string, and you might
want to get the first one only then

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.