[Bug 657319] videorate should use basetransform

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=657319
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194839|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge <slomo at circular-chaos.org> 2011-08-30 15:01:44 UTC ---
Review of attachment 194839:
 --> (https://bugzilla.gnome.org/review?bug=657319&attachment=194839)

Looks good in general (and you can use basetransform for non-1-to-1 elements,
see audiofirfilter for example, you just have to handle additional buffers
yourself and drop buffers with GST_BASE_TRANSFORM_FLOW_DROPPED)

::: gst/videorate/gstvideorate.c
@@ +285,3 @@
 {
+  GstStructure *s;
+  gint nom, denom;

It's numerator, not nomerator/nominator ;)

@@ +302,3 @@
   GstStructure *structure;
   gboolean ret = TRUE;
+  //GstPad *otherpad, *opeer;

C++/C99 comment

@@ -407,3 @@
-      if (gst_structure_has_field (structure, "pixel-aspect-ratio"))
-        gst_structure_fixate_field_nearest_fraction (structure,
-            "pixel-aspect-ratio", 1, 1);

These fixations might still be necessary in the fixate vfunc

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.