[Bug 657872] XDG mime type finder identify SRT as application/x-subrip

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Aug 31 18:02:17 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=657872
  GStreamer | gst-plugins-base | git

--- Comment #6 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-09-01 01:02:12 UTC ---
Created an attachment (id=195359)
 View: https://bugzilla.gnome.org/attachment.cgi?id=195359
 Review: https://bugzilla.gnome.org/review?bug=657872&attachment=195359

subparse: Improve subrip type check regex

This patch prevents timestamp like "1 1:00:00", which would have been seen
as hour 101 by our parser, and allow single digit hour, minute and seconds
as it's already supported by the parser, and also by other implementation
like in mplayer.

Note that this does not fix the problem with XDG reporting bad types. To follow
current code, we could ignore known subtitle types from xdg reply. Here's the
list from freedesktop database. I guess they should be removed if we support
them, some of them are being match using pattern (e.g. microdvd, mpsub,
subviewer etc. shares extension .sub).

application/x-subrip (.srt)
application/x-sami (.smi .sami)
text/x-microdvd (.sub)
text/x-mpsub (.sub)
text/x-ssa (.ssa .ass)
text/x-subviewer (.sub)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list