[Bug 651443] multifilesink: add next-file=max-size mode and max-file-size property

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=651443
  GStreamer | gst-plugins-good | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.31
            Summary|Adding a size-limit         |multifilesink: add
                   |property to multifilesink   |next-file=max-size mode and
                   |                            |max-file-size property

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-12-01 13:16:59 UTC ---
Pushed this now:

 commit ab96fb7cdb9048d1b8205293f82ef17dad80e7f1
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Sun Sep 25 14:57:56 2011 +0100

    multifilesink: add basic buffer list handling

    We assume for now that all buffers in a buffer list
    should end up in the same file (so we can group GOPs
    in buffer lists, for example). Could optimise this
    a bit to avoid the memcpy.

 commit 82ac47f33fbf9d4d3b79824f2d39dde810cb4cfc
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Fri Sep 23 18:43:35 2011 +0100

    multifilesink: write stream-headers when switching to the next file in
max-size mode

 commit bced3c218a795992dd8a9b60d5d38f35fa5c0b4b
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Fri Sep 23 18:31:01 2011 +0100

    multifilesink: add new 'max-size' mode for switching to the next file

 commit 5ffee06f14e3b40208a3a127a0196dfa70d7a426
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Fri Sep 23 17:49:05 2011 +0100

    multifilesink: add "max-file-size" property for new next-file mode


Your naming (with '-limit') might be nicer though, but the max-*size is more in
line with what we use for e.g. queues. I don't really mind. If anyone has a
strong opinion on this, we can still change it :)

I've pushed my patches now since I know they've been tested and because I'm not
convinced yours is entirely right as is (e.g. if you call it a limit, it should
be a hard limit IMHO, but the way I read your patch is that you only start a
new file once you're over the limit).

Please test it and let us know if there are any problems.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.