[Bug 660233] DVB subtitles stop being rendered

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=660233
  GStreamer | gst-plugins-bad | 0.10.22

Mart Raudsepp <leio> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |leio at gentoo.org
     Ever Confirmed|0                           |1

--- Comment #2 from Mart Raudsepp <leio at gentoo.org> 2011-12-10 06:39:29 UTC ---
0xFFFFFFFFFFFFFFFF == GST_CLOCK_TIME_NONE == (unsigned int) -1

So new_dvb_subtitles_cb is called with subs->pts set to GST_CLOCK_TIME_NONE or
-1.
This originates from deeper interaction with dvb-sub.c through callbacks, but
basically gstreamer side gives the pts that is stored in the subtitle
structures with the call to dvb_sub_feed_with_pts() via
gst_dvbsub_overlay_process_text().
This usage comes with a FIXME comment from me:

/* FIXME: We are abusing libdvbsub pts value for tracking our gstreamer running
time instead of real PTS. Should be mostly fine though... */

Apparently it isn't completely fine then :(
It would be GST_CLOCK_TIME_NONE or -1 if the gst_segment_to_running_time call
is returning it, and it can return -1 per documentation if the position is
outside of segment start and stop.
So I suspect we should be dropping it there already then, not push it to the
GQueue via _process_text(), but I'd need to think a bit further regarding the
segments handling.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.