[Bug 665988] mpegtsparse: segfault on malformed packets when retrieving table_id

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=665988
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203238|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2011-12-12 12:37:59 UTC ---
Review of attachment 203238:
 --> (https://bugzilla.gnome.org/review?bug=665988&attachment=203238)

::: gst/mpegdemux/mpegtsparse.c
@@ +895,3 @@
       data += pointer;
+      if (!(data - GST_BUFFER_DATA (packet->buffer) <
+              GST_BUFFER_SIZE (packet->buffer))) {

This check is not very intuitive, maybe add a comment here why this is a
problem

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.